Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse more exclusive range patterns and inline const patterns #14580

Merged
merged 2 commits into from Apr 15, 2023
Merged

Parse more exclusive range patterns and inline const patterns #14580

merged 2 commits into from Apr 15, 2023

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Apr 15, 2023

Closes #13955

This PR

  • implements exclusive range pattern without start bound (tracking issue: Tracking issue for exclusive range patterns rust#37854)
    • additionally moves rest pattern handling into the same place since they only differ in whether another pattern follows; this actually solves some FIXMEs
  • updates PATTERN_FIRST token set to include const token so we can parse inline const pattern in nested patterns

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2023
@lowr lowr closed this Apr 15, 2023
@lowr lowr deleted the patch/parse-more-unstable-pat branch April 15, 2023 19:36
@lowr lowr restored the patch/parse-more-unstable-pat branch April 15, 2023 19:37
@lowr lowr reopened this Apr 15, 2023
@lowr
Copy link
Contributor Author

lowr commented Apr 15, 2023

Accidentally deleted the branch because I suck at git :( There should be no problem in the PR itself.

@Veykril
Copy link
Member

Veykril commented Apr 15, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 15, 2023

📌 Commit 83a93f4 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Apr 15, 2023

⌛ Testing commit 83a93f4 with merge c28f538...

@bors
Copy link
Collaborator

bors commented Apr 15, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing c28f538 to master...

@bors bors merged commit c28f538 into rust-lang:master Apr 15, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax error when using const + exclusive range pattern syntax
4 participants
@lowr @Veykril @bors @rustbot