fix: implemeted lifetime transformation fot assits #14875
Conversation
rustbot
added
the
S-waiting-on-review
crates/ide-db/src/path_transform.rs
Outdated
| .into_iter() | ||
| .flat_map(|it| it.lifetime_params(db)) | ||
| .zip(self.substs.lifetimes.clone()) | ||
| .filter_map(|(k, v)| Some((k.name(db).to_string(), v.lifetime()?))) |
There was a problem hiding this comment.
todo: lifetime resolver is already written, could I reuse it somehow?
upd: I believe I shouldn't.
basically this resolver traverses through a ast::Lifetime's ancestors looking for one with the same name, then converts the found ast::LifetimeParam to hir::LifetimeParam. in our case, there's no need neither in conversion nor in the search, as all the lifetimes to be changed are generic params of a known ancestor, the source trait.
(but I don't really understand why SemanticsScope can't resolve a lifetime)
crates/hir/src/lib.rs
Outdated
| self.lifetime_params(db).into_iter().chain(ty_params).collect() | ||
| } | ||
|
|
||
| pub fn lifetime_params(self, db: &dyn HirDatabase) -> Vec<GenericParam> { |
There was a problem hiding this comment.
| pub fn lifetime_params(self, db: &dyn HirDatabase) -> Vec<GenericParam> { | |
| pub fn lifetime_params(self, db: &dyn HirDatabase) -> Vec<LifetimeParam> { |
crates/ide-db/src/path_transform.rs
Outdated
| @@ -9,6 +9,14 @@ use syntax::{ | |||
| ted, SyntaxNode, | |||
| }; | |||
|
|
|||
| #[derive(Default)] | |||
| struct Substs { | |||
There was a problem hiding this comment.
nit, let's rename this to AstSubsts as we might have Substs in the hir layer in the future
Veykril
added
S-waiting-on-author
… assists transform lifetimes
ponyii
force-pushed
the
fix/implement-missing-members-do-not-transform-lifetimes
branch
from
ba6e7ce
to
7f45ccc
Compare
|
Thanks! |
|
☀️ Test successful - checks-actions |
A part of #13363
I expect to implement transformation of const params in a separate PR
Other assists and a completion affected:
generate_functioncurrently just ignores lifetimes and, consequently, is not affectedinline_callandreplace_derive_with...don't seem to need lifetime transformationtrait_impl(a completion) is fixed and tested