Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a toggle to disable the dependency explorer #14906

Merged

Conversation

davidbarsky
Copy link
Contributor

For common uses of non-Cargo build systems with rust-analyzer, the dependency view isn't particularly helpful because there isn't a Cargo.toml present for dependencies or the dependencies are part of the current workspace.

Speaking from the perspective of a user of rust-project.json, I'd prefer to have this feature disabled until I can add a field to Crate that defines the location of a build file (e.g., a BUCK) file, which would allow for removing the "search for a Cargo.toml in parent directories of a crate root" behavior that exists in a few places (I've opened an issue on Cargo to request this data from cargo-metadata).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2023
@davidbarsky
Copy link
Contributor Author

If you accept this, let me know if you'd like me to update the user-facing documentation, since it might not be automatically generated.

@Veykril
Copy link
Member

Veykril commented May 26, 2023

Do we even document any vscode specific settings? 😅

@davidbarsky
Copy link
Contributor Author

Hmm, now that you mentioned it, I don't think rust-analyzer does.

@Veykril
Copy link
Member

Veykril commented May 26, 2023

Our documentation is very lackluster in general
@bors r+

@bors
Copy link
Collaborator

bors commented May 26, 2023

📌 Commit 7dfef85 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 26, 2023

⌛ Testing commit 7dfef85 with merge 08f0c29...

@bors
Copy link
Collaborator

bors commented May 26, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 08f0c29 to master...

@bors bors merged commit 08f0c29 into rust-lang:master May 26, 2023
10 checks passed
@davidbarsky davidbarsky deleted the davidbarsky/add-option-to-disable-explorer branch May 26, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants