Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rustup installation description #14914

Merged
merged 2 commits into from May 27, 2023

Conversation

mashuler
Copy link
Contributor

While going through the process of installing rust-analyzer to use with Neovim, I noticed that the instructions for installing with rustup are incorrect now that issue #2411 has been closed. Now when rust-analyzer is installed using rustup, it is installed in ~/.cargo/bin and a symlink or some other workaround is no longer needed. I have updated the documentation accordingly.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2023
@lnicola
Copy link
Member

lnicola commented May 27, 2023

Thanks!

@bors r+

Note that this is still incomplete, as:

  • we currently don't recommend using this distribution method
  • the shim interacts in a nasty way with a binary acquired with a different method

changelog internal (first contribution) update outdated rustup installation instructions

@bors
Copy link
Collaborator

bors commented May 27, 2023

📌 Commit 05d63ef has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 27, 2023

⌛ Testing commit 05d63ef with merge f6e3a87...

@bors
Copy link
Collaborator

bors commented May 27, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing f6e3a87 to master...

@bors bors merged commit f6e3a87 into rust-lang:master May 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants