Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add render configs for memory layout hovers #14929

Merged
merged 1 commit into from May 30, 2023
Merged

fix: Add render configs for memory layout hovers #14929

merged 1 commit into from May 30, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented May 30, 2023 •
edited

Closes #14918

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2023
HKalbasi
HKalbasi reviewed May 30, 2023
View reviewed changes
crates/ide/src/hover/tests.rs Outdated
@@ -237,7 +244,7 @@ fn main() {
expect![[r#"
*|*
```rust
{closure#0} // size = 8, align = 8
{closure#0} // size = 8 (0x8), align = 8 (0x8), , niches = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can avoid hex for 0..9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean 0..=9 :p

@Veykril Veykril force-pushed the hover-hex branch 2 times, most recently from 4e6cce6 to 4bc5087 Compare May 30, 2023 16:26
@Veykril
Copy link
Member Author

Veykril commented May 30, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented May 30, 2023

📌 Commit 3c86250 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 30, 2023

⌛ Testing commit 3c86250 with merge d2b3caa...

@bors
Copy link
Collaborator

bors commented May 30, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d2b3caa to master...

@bors bors merged commit d2b3caa into rust-lang:master May 30, 2023
10 checks passed
@lnicola lnicola changed the title Add render configs for memory layout hovers fix: Add render configs for memory layout hovers May 30, 2023
@lnicola lnicola mentioned this pull request Jun 1, 2023
Merged
@Veykril Veykril deleted the hover-hex branch August 2, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowr lowr lowr left review comments

@HKalbasi HKalbasi HKalbasi left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to change hexadecimal size display to decimal
5 participants
@Veykril @bors @lowr @HKalbasi @rustbot