Properly format documentation for SignatureHelpRequests

[max-heller]

Properly formats function documentation instead of returning it raw when responding to SignatureHelpRequests.

I added a test in crates/rust-analyzer/tests/slow-tests/main.rs -- not sure if this is the best location given the relevant code is in crates/rust-analyzer or if it's possible to test in a less heavyweight manner.

Closes #14958

[lowr]

Fix looks good, thanks!

As for the test, a slow test for this sounds a bit overkill. I think we can write a lighter test similar to this. The procedure would be like:

1. feed test fixture to Analysis::from_single_file()
2. call analysis.signature_help() and get SignatureHelp
3. feed it to signature_help() (the one you're fixing) and assert it successfully hides ignored code

Can you try making such test? Let me know if there's anything unclear! Also, since the changes are pretty small, you can squash everything into one commit and just force push it.

[max-heller]

Can you try making such test? Let me know if there's anything unclear! Also, since the changes are pretty small, you can squash everything into one commit and just force push it.

Done, thanks!

[lowr]

All looks great, thank you!

[lowr]

@bors r+

[bors]

📌 Commit 78fab7d has been approved by lowr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 78fab7d with merge 68bdf60...

[bors]

☀️ Test successful - checks-actions
Approved by: lowr
Pushing 68bdf60 to master...