internal: Migrate some assists to use the structured snippet API #14979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`replace_derive_with_manual_impl` was slightly since it used `add_trait_assoc_items_to_impl` (which was also used by `add_missing_impl_members`)
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jul 10, 2023
internal: Migrate more assists to use the structured snippet API Continuing from #14979 Migrates the following assists: - `generate_derive` - `wrap_return_type_in_result` - `generate_delegate_methods` As a bonus, `generate_delegate_methods` now generates the function and impl block at the correct indentation 🎉.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the following assists:
add_missing_impl_membersextract_type_aliasAs an additional requirement, these assists are also migrated to use the mutable AST API, since otherwise there would be overlapping
Indelspans