fix: deduplicate fields and types in completion #15026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Jun 12, 2023
|
I never realized that you could have cycles in deref targets 😨 |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jun 13, 2023
Deduplicate tuple indices for completion Follow-up to #15026 A tuple struct may dereference to a primitive tuple (though unusual, which is why I previously overlooked this case). We should not show the same tuple index in completion in such cases. Deduplication of indices among multiple tuple structs is already handled in the previous PR.
bors
added a commit
that referenced
this pull request
Jun 13, 2023
Deduplicate tuple indices for completion Follow-up to #15026 A tuple struct may dereference to a primitive tuple (though unusual, which is why I previously overlooked this case). We should not show the same tuple index in completion in such cases. Deduplication of indices among multiple tuple structs is already handled in the previous PR.
bors
added a commit
that referenced
this pull request
Jun 13, 2023
Deduplicate tuple indices for completion Follow-up to #15026 A tuple struct may dereference to a primitive tuple (though unusual, which is why I previously overlooked this case). We should not show the same tuple index in completion in such cases. Deduplication of indices among multiple tuple structs is already handled in the previous PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15024
hir_ty::autoderef()(which is only meant to be used outsidehir-ty) now deduplicates types and completely resolves inference variables within.