Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Give rustfmt jobs a separate thread #15028

Merged
merged 2 commits into from Jun 11, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 11, 2023

Some light testing suggests that this fixes the waiting on formatting popup in vscode when the project is still building (which is usually the way for me to encounter it, as r-a is either waiting or getting little resources causing the tasks to block formatting)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2023
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
@Veykril
Copy link
Member Author

Veykril commented Jun 11, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2023

📌 Commit 179b8d7 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 11, 2023

⌛ Testing commit 179b8d7 with merge d567091...

@bors
Copy link
Collaborator

bors commented Jun 11, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d567091 to master...

@bors bors merged commit d567091 into rust-lang:master Jun 11, 2023
10 checks passed
@Veykril Veykril deleted the rustfmt-thread branch June 11, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants