Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(metrics): Run measurement functions in parallel #15030

Merged
merged 5 commits into from Jun 28, 2023

Conversation

NanthR
Copy link
Contributor

@NanthR NanthR commented Jun 11, 2023

Resolves #14853

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2023
feat(xtask): Split metrics function
xtask/src/flags.rs Outdated Show resolved Hide resolved
xtask/src/flags.rs Show resolved Hide resolved
@HKalbasi
Copy link
Member

The implementation looks good to me. Is there a way to test it before merge?

@NanthR
Copy link
Contributor Author

NanthR commented Jun 24, 2023

@HKalbasi, I have pushed both the old and new version of the workflow file to a repo and the metrics have been pushed to https://github.com/NanthR/metrics. The old and new branches have the appropriate metrics files. Running a diff on them doesn't seem to have any issues. Let me know if there is anything else that needs to be done?

@HKalbasi
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

📌 Commit cf34df0 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

⌛ Testing commit cf34df0 with merge ac4e046...

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing ac4e046 to master...

@bors bors merged commit ac4e046 into rust-lang:master Jun 28, 2023
10 checks passed
@HKalbasi
Copy link
Member

cd metrics
git add .
git -c user.name=Bot -c user.email=dummy@example.com commit --message 📈
git push origin new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be master instead of new?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Sorry. Remnant from my testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make metrics parallel
8 participants