New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(metrics): Run measurement functions in parallel #15030
Conversation
feat(xtask): Split metrics function
The implementation looks good to me. Is there a way to test it before merge? |
@HKalbasi, I have pushed both the old and new version of the workflow file to a repo and the metrics have been pushed to https://github.com/NanthR/metrics. The old and new branches have the appropriate metrics files. Running a diff on them doesn't seem to have any issues. Let me know if there is anything else that needs to be done? |
Thanks! |
☀️ Test successful - checks-actions |
@NanthR it failed, can you take a look? https://github.com/rust-lang/rust-analyzer/actions/runs/5402910351/jobs/9815765491 |
cd metrics | ||
git add . | ||
git -c user.name=Bot -c user.email=dummy@example.com commit --message 📈 | ||
git push origin new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be master
instead of new
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Sorry. Remnant from my testing
Resolves #14853