Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude Markdown injection grammar from .vscodeignore. #15032

Merged
merged 1 commit into from Jun 12, 2023

Conversation

AndreasBackx
Copy link
Contributor

@AndreasBackx AndreasBackx commented Jun 12, 2023

Enables Markdown injection introduced in #14866 but wasn't included in release due to the grammar file being ignored by .vscodeignore. I verified the fix by doing vsce package and installing it manually:

image image

Enables Markdown injection introduced in rust-lang#14866 but wasn't included in release due to it being ignored.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2023
@AndreasBackx AndreasBackx changed the title Exclude Markdown injection grammar from .vscodeignore. fix: exclude Markdown injection grammar from .vscodeignore. Jun 12, 2023
@lnicola
Copy link
Member

lnicola commented Jun 12, 2023

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 12, 2023

📌 Commit 942b392 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 12, 2023

⌛ Testing commit 942b392 with merge 38c47df...

@bors
Copy link
Collaborator

bors commented Jun 12, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 38c47df to master...

@bors bors merged commit 38c47df into rust-lang:master Jun 12, 2023
10 checks passed
@AndreasBackx AndreasBackx deleted the fix/vscode-markdown branch June 12, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants