Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Record file dependencies in crate graph construction #15047

Merged
merged 1 commit into from Jun 13, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 13, 2023

Should fix the bug mentioned in #8623 where removing a crate root file will panic. I'm not too happy with the way this is done here but I can't think of a better way right now.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2023
@Veykril
Copy link
Member Author

Veykril commented Jun 13, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 13, 2023

📌 Commit b322805 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 13, 2023

⌛ Testing commit b322805 with merge f8dec25...

@bors
Copy link
Collaborator

bors commented Jun 13, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f8dec25 to master...

@bors bors merged commit f8dec25 into rust-lang:master Jun 13, 2023
10 checks passed
@Veykril Veykril deleted the crate-graph-root-deps branch June 13, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants