Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: implement missing members doesn't transform const params and default types #15054

Merged
merged 4 commits into from Jun 18, 2023
Merged

fix: implement missing members doesn't transform const params and default types #15054

merged 4 commits into from Jun 18, 2023

Conversation

ponyii
Copy link
Contributor

@ponyii ponyii commented Jun 14, 2023

Fixes #13363

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2023
ponyii
ponyii commented Jun 14, 2023
View reviewed changes
crates/ide-db/src/path_transform.rs Outdated
};
Some((k, subst))
}
(Either::Left(_), None) => None, // FIXME: get default const value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems impossible to get default const values from hir right now; I hope to fix this line after patching hir

see https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/hir.20.26.20generic.20const.20params/near/365836700

lowr
lowr reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@lowr lowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making path transformer better and better! I've done the initial review.

crates/ide-db/src/path_transform.rs Outdated Show resolved Hide resolved
crates/ide-db/src/path_transform.rs Outdated Show resolved Hide resolved
crates/ide-db/src/path_transform.rs Outdated Show resolved Hide resolved
crates/ide-db/src/path_transform.rs Outdated Show resolved Hide resolved
@ponyii ponyii force-pushed the fix/implement-missing-members-do-not-transform-const-params branch from b50a9a9 to 499b09c Compare June 15, 2023 15:50
@ponyii ponyii requested a review from lowr June 15, 2023 15:58
@ponyii ponyii force-pushed the fix/implement-missing-members-do-not-transform-const-params branch 3 times, most recently from 15a31e9 to c84370c Compare June 16, 2023 16:30
@ponyii ponyii force-pushed the fix/implement-missing-members-do-not-transform-const-params branch from c84370c to 7e08933 Compare June 16, 2023 16:34
@ponyii ponyii requested a review from lowr June 16, 2023 16:45
@lowr
Copy link
Contributor

lowr commented Jun 18, 2023

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 18, 2023

📌 Commit 7e08933 has been approved by lowr

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 18, 2023

⌛ Testing commit 7e08933 with merge a1b536e...

@bors
Copy link
Collaborator

bors commented Jun 18, 2023

☀️ Test successful - checks-actions
Approved by: lowr
Pushing a1b536e to master...

@bors bors merged commit a1b536e into rust-lang:master Jun 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowr lowr Awaiting requested review from lowr

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"implement missing members" assist uses incorrect lifetime name
4 participants
@ponyii @lowr @bors @rustbot