Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Change in-tree libs to workspace dependencies and bump versions #15095

Merged
merged 3 commits into from Jun 20, 2023
Merged

internal: Change in-tree libs to workspace dependencies and bump versions #15095

merged 3 commits into from Jun 20, 2023

Conversation

davidlattimore
Copy link
Contributor

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2023
@davidlattimore
Copy link
Contributor Author

rust-analyzer doesn't build with the version of la-arena that's currently on crates.io. Bumping lsp-server is mostly just because there are a number of fixes since the last release. #15095

I confirmed that cargo semver-checks check-release appeared happy for these to be patch version bumps, but I can bump the minor version number instead if you prefer.

We may switch to using these libs from crates.io rather than from the lib directory, but doing that would need to be a separate PR, since it can only be done after the new versions are released - which should be be done automatically by the publish-libs workflow once this PR is merged.

@lnicola
Copy link
Member

lnicola commented Jun 20, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

📌 Commit fb3e54e has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

⌛ Testing commit fb3e54e with merge 7ebe7ac...

@bors
Copy link
Collaborator

bors commented Jun 20, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 7ebe7ac to master...

@bors bors merged commit 7ebe7ac into rust-lang:master Jun 20, 2023
10 checks passed
@lnicola lnicola changed the title Change in-tree libs to workspace dependencies and bump versions internal: Change in-tree libs to workspace dependencies and bump versions Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlattimore @lnicola @bors @rustbot