internal: Use lib crates from crates.io #15098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
This should help reduce breakages to the autopublish workflow. #15038 |
Veykril
reviewed
Jun 21, 2023
Comment on lines
-79
to
+86
| # In-tree crates that are published separately and follow semver. | ||
| line-index = { version = "0.1.0-pre.1", path = "lib/line-index" } | ||
| la-arena = { version = "0.3.1", path = "lib/la-arena" } | ||
| lsp-server = { version = "0.7.1", path = "lib/lsp-server" } | ||
| # In-tree crates that are published separately and follow semver. See lib/README.md | ||
| line-index = { version = "0.1.0-pre.1" } | ||
| la-arena = { version = "0.3.1" } | ||
| lsp-server = { version = "0.7.1" } |
There was a problem hiding this comment.
Up above is a [patch.'crates-io'] section with a lot of commented out patches, could you add commented out path versions for these there? That would make it easier to use the local ones on demand for testing.
There was a problem hiding this comment.
Good idea. Done. I also amended the last bit that I'd added to libs/README.md accordingly.
See lib/README.md for justification
davidlattimore
force-pushed
the
libs-from-crates-io
branch
from
7bcd75d
to
5c8d1a4
Compare
|
Thanks |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See lib/README.md for justification