Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip mutable diagnostics on synthetic bindings #15104

Merged
merged 1 commit into from Jun 21, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 21, 2023

Fixes #15099

We probabnly need to look into this in a more general manner in the future now that we desugar more things

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2023
@Veykril
Copy link
Member Author

Veykril commented Jun 21, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 21, 2023

📌 Commit d8b970f has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 21, 2023

⌛ Testing commit d8b970f with merge 85493df...

@bors
Copy link
Collaborator

bors commented Jun 21, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 85493df to master...

@bors bors merged commit 85493df into rust-lang:master Jun 21, 2023
8 checks passed
@lnicola lnicola changed the title Skip mutable diagnostics on synthetic bindings fix: Skip mutable diagnostics on synthetic bindings Jun 22, 2023
@Veykril Veykril deleted the mir-borrow-synthetic branch August 2, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreachable code in crate inside a workspace causes rust-analyzer to crash
3 participants