Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Add run-tests command #15110

Merged
merged 1 commit into from Jun 22, 2023
Merged

Conversation

HKalbasi
Copy link
Member

This command is similar to cargo test except that it uses r-a to run tests instead of compiling and running them with rustc. This is slower than cargo test and it is only useful for me to see a bird view of what needs to be fixed. The current output is:

48 passed, 5028 failed, 2 ignored
All tests            174.74s, 648ginstr

48 is very low, but higher than what I originally thought.

Now that there is some passing tests, I can show the plan:

s.mp4

That is, at the end, I want to be able to immediately re run every test after every change. (0.5s is not really immediate, but it's not finished yet, and it is way better than 8s that running a typical test in r-a will take on my system)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2023
@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

📌 Commit 421200d has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

⌛ Testing commit 421200d with merge 3c4f80f...

bors added a commit that referenced this pull request Jun 22, 2023
internal: Add run-tests command

This command is similar to `cargo test` except that it uses r-a to run tests instead of compiling and running them with rustc. This is slower than `cargo test` and it is only useful for me to see a bird view of what needs to be fixed. The current output is:
```
48 passed, 5028 failed, 2 ignored
All tests            174.74s, 648ginstr
```
48 is very low, but higher than what I originally thought.

Now that there is some passing tests, I can show the plan:

https://github.com/rust-lang/rust-analyzer/assets/45197576/76d7d777-1843-4ca4-b7fe-e463bdade6cb

That is, at the end, I want to be able to immediately re run every test after every change. (0.5s is not really immediate, but it's not finished yet, and it is way better than 8s that running a typical test in r-a will take on my system)
@bors
Copy link
Collaborator

bors commented Jun 22, 2023

💔 Test failed - checks-actions

@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

📌 Commit 958f93b has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

⌛ Testing commit 958f93b with merge 1225097...

bors added a commit that referenced this pull request Jun 22, 2023
internal: Add run-tests command

This command is similar to `cargo test` except that it uses r-a to run tests instead of compiling and running them with rustc. This is slower than `cargo test` and it is only useful for me to see a bird view of what needs to be fixed. The current output is:
```
48 passed, 5028 failed, 2 ignored
All tests            174.74s, 648ginstr
```
48 is very low, but higher than what I originally thought.

Now that there is some passing tests, I can show the plan:

https://github.com/rust-lang/rust-analyzer/assets/45197576/76d7d777-1843-4ca4-b7fe-e463bdade6cb

That is, at the end, I want to be able to immediately re run every test after every change. (0.5s is not really immediate, but it's not finished yet, and it is way better than 8s that running a typical test in r-a will take on my system)
@bors
Copy link
Collaborator

bors commented Jun 22, 2023

💔 Test failed - checks-actions

@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

📌 Commit 674cd5a has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

⌛ Testing commit 674cd5a with merge 3a4f9a1...

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 3a4f9a1 to master...

@bors bors merged commit 3a4f9a1 into rust-lang:master Jun 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants