New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Add run-tests command #15110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 22, 2023
@bors r+ |
bors
added a commit
that referenced
this pull request
Jun 22, 2023
internal: Add run-tests command This command is similar to `cargo test` except that it uses r-a to run tests instead of compiling and running them with rustc. This is slower than `cargo test` and it is only useful for me to see a bird view of what needs to be fixed. The current output is: ``` 48 passed, 5028 failed, 2 ignored All tests 174.74s, 648ginstr ``` 48 is very low, but higher than what I originally thought. Now that there is some passing tests, I can show the plan: https://github.com/rust-lang/rust-analyzer/assets/45197576/76d7d777-1843-4ca4-b7fe-e463bdade6cb That is, at the end, I want to be able to immediately re run every test after every change. (0.5s is not really immediate, but it's not finished yet, and it is way better than 8s that running a typical test in r-a will take on my system)
💔 Test failed - checks-actions |
HKalbasi
force-pushed
the
run-test-command
branch
from
June 22, 2023 15:52
421200d
to
958f93b
Compare
@bors r+ |
bors
added a commit
that referenced
this pull request
Jun 22, 2023
internal: Add run-tests command This command is similar to `cargo test` except that it uses r-a to run tests instead of compiling and running them with rustc. This is slower than `cargo test` and it is only useful for me to see a bird view of what needs to be fixed. The current output is: ``` 48 passed, 5028 failed, 2 ignored All tests 174.74s, 648ginstr ``` 48 is very low, but higher than what I originally thought. Now that there is some passing tests, I can show the plan: https://github.com/rust-lang/rust-analyzer/assets/45197576/76d7d777-1843-4ca4-b7fe-e463bdade6cb That is, at the end, I want to be able to immediately re run every test after every change. (0.5s is not really immediate, but it's not finished yet, and it is way better than 8s that running a typical test in r-a will take on my system)
💔 Test failed - checks-actions |
HKalbasi
force-pushed
the
run-test-command
branch
from
June 22, 2023 16:03
958f93b
to
674cd5a
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command is similar to
cargo test
except that it uses r-a to run tests instead of compiling and running them with rustc. This is slower thancargo test
and it is only useful for me to see a bird view of what needs to be fixed. The current output is:48 is very low, but higher than what I originally thought.
Now that there is some passing tests, I can show the plan:
s.mp4
That is, at the end, I want to be able to immediately re run every test after every change. (0.5s is not really immediate, but it's not finished yet, and it is way better than 8s that running a typical test in r-a will take on my system)