Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markdown injection again #15116

Merged
merged 1 commit into from Jun 23, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 23, 2023

I really tried to make this work, but this stuff is so underdocumented and basically none of the regex options worked for me (not match, nor using begin and end pairs), VSCode basically doesn't help you out at all as it doesn't ever seem to report errors even when debugging an extension, so at this point I'm inclined to just remove this again, as it is only causing issues.

I'm happy to get this back if someone manages to figure out how to make this work properly

Closes #15114
Closes #15111

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2023
@Veykril
Copy link
Member Author

Veykril commented Jun 23, 2023

merging for now so i can kick off a new nightly as that issue is really annoying me right now
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2023

📌 Commit 0141a6b has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 23, 2023

⌛ Testing commit 0141a6b with merge 246d11b...

@Veykril
Copy link
Member Author

Veykril commented Jun 23, 2023

Fyi @AndreasBackx

@bors
Copy link
Collaborator

bors commented Jun 23, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 246d11b to master...

@bors bors merged commit 246d11b into rust-lang:master Jun 23, 2023
7 of 8 checks passed
@AndreasBackx
Copy link
Contributor

Understandable, I'm on holiday for the month of June. I think I might create an extension for myself and publish it, fix issues as I see them. Then if anyone wants it, they can opt-in instead of breaking syntax highlighting for every rust-analyzer user.

TextMate grammar is horribly undocumented, I have a few sources saved that I reference. Though they still leave you guessing with injection and more advanced uses. I've figured out some weird things, though it's still a lot if trial and error. I wish someone who implemented it for VS Code, TextMate, or elsewhere can help document the space better.

@Veykril Veykril deleted the remove-markdown-injection branch June 24, 2023 07:17
@lnicola lnicola mentioned this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only initial /// is highlighted in doc comments Outer line docs italicises entire code block
4 participants