Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Add the comment why HasSource::source() returns Option #15140

Merged
merged 1 commit into from Jun 26, 2023

Conversation

tetsuharuohzeki
Copy link
Contributor

Fix #15088

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2023
@Veykril
Copy link
Member

Veykril commented Jun 26, 2023

Thanks! And a bigger thanks for realizing that this change was intentionally made :)
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 26, 2023

📌 Commit 7b418d3 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 26, 2023

⌛ Testing commit 7b418d3 with merge 8769cd2...

@bors
Copy link
Collaborator

bors commented Jun 26, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8769cd2 to master...

@bors bors merged commit 8769cd2 into rust-lang:master Jun 26, 2023
6 of 10 checks passed
@tetsuharuohzeki tetsuharuohzeki deleted the issue-15088-comment branch June 26, 2023 10:36
@lnicola lnicola changed the title Add the comment why HasSource::source() returns Option internal: Add the comment why HasSource::source() returns Option Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HasSource::source should be infallible
4 participants