Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies for editor/code #15151

Merged
merged 13 commits into from Jun 27, 2023
Merged

Update dependencies for editor/code #15151

merged 13 commits into from Jun 27, 2023

Conversation

tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzeki tetsuharuohzeki commented Jun 27, 2023 •
edited

This updates dependencies except @types/node.

@tetsuharuohzeki
Update typescript to v5.1
1ec07fd 
- https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/
- https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/
@tetsuharuohzeki
Update typescript-eslint to v5.60
c086389 
https://github.com/typescript-eslint/typescript-eslint/releases
@tetsuharuohzeki
Update tslib
9a0a0a0 
https://github.com/microsoft/tslib/releases
@tetsuharuohzeki
Update prettier
8769df9 
https://github.com/prettier/prettier/blob/main/CHANGELOG.md
@tetsuharuohzeki
Update @vscode/test-electron
2f7a16c 
https://github.com/microsoft/vscode-test/blob/main/CHANGELOG.md
@tetsuharuohzeki
Update ESLint
1bfdcb2 
https://eslint.org/blog/category/release-notes/
@tetsuharuohzeki
Update vscode-languageclient
95e4c66 
https://github.com/Microsoft/vscode-languageserver-node
@tetsuharuohzeki
Update @hpcc-js/wasm
658831c 
https://github.com/hpcc-systems/hpcc-js-wasm
@tetsuharuohzeki
Update d3
6454b5a 
https://github.com/d3/d3
@tetsuharuohzeki
Update ovsx
9870aa0 
https://github.com/amvanbaren/openvsx/blob/aa90b01b1377a5035372614d74d0c647e798b135/cli/CHANGELOG.md
@tetsuharuohzeki
Update esbuild
9930889 
- https://github.com/evanw/esbuild/blob/main/CHANGELOG-2022.md
- https://github.com/evanw/esbuild/blob/main/CHANGELOG.md
@tetsuharuohzeki
Regenerate package-lock.json
35184be
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2023
@lnicola
Copy link
Member

lnicola commented Jun 27, 2023

This updates dependencies except @types/node and @types/vscode

I think we can bump Code too to 1.78.

@tetsuharuohzeki
Copy link
Contributor Author

This updates dependencies except @types/node and @types/vscode

I think we can bump Code too to 1.78.

That changes our extension's minimum support versions, so I thought we should do it in a separate pull request.
Should we do that in this?

@lnicola
Copy link
Member

lnicola commented Jun 27, 2023

We nominally support the latest two versions, it's probably fine to do it here. And I don't think the supported version actually changes unless you also bump engine somewhere else in the same file.

@tetsuharuohzeki
Copy link
Contributor Author

We nominally support the latest two versions, it's probably fine to do it here. And I don't think the supported version actually changes unless you also bump engine somewhere else in the same file.

Okay, I update my changeset.

lnicola
lnicola approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That diffstat is certainly intriguing. I think we should merge this sooner rather than later, so we have time to spot any issues before the next release.

@tetsuharuohzeki
Copy link
Contributor Author

@lnicola CI has passed.

@lnicola
Copy link
Member

lnicola commented Jun 27, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 27, 2023

📌 Commit 1b228f9 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 27, 2023

⌛ Testing commit 1b228f9 with merge 7c8ae35...

@bors
Copy link
Collaborator

bors commented Jun 27, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 7c8ae35 to master...

@bors bors merged commit 7c8ae35 into rust-lang:master Jun 27, 2023
10 checks passed
@bors bors mentioned this pull request Jun 27, 2023
Closed
@tetsuharuohzeki tetsuharuohzeki deleted the update-deps-code-ext branch June 27, 2023 17:38
@tetsuharuohzeki tetsuharuohzeki mentioned this pull request Jun 30, 2023
Merged
bors added a commit that referenced this pull request Jun 30, 2023
@bors
Auto merge of #15174 - tetsuharuohzeki:switch-to-use-vscode-vcse, r=V…
40b2a68 
…eykril

editor/code: Switch to `@vscode/vsce`

This follows up #15151

`vsce` was renamed to ``@vscode/vsce`.` We should switch to it now.

- https://code.visualstudio.com/updates/v1_74#_extension-authoring
- https://www.npmjs.com/package/`@vscode/vsce`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tetsuharuohzeki @lnicola @bors @rustbot