assist : generate trait from impl #15152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Jun 28, 2023
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
|
@bors r+ |
|
@bors r- I've started reviewing but haven't gotten time to finish it. I'm really sorry for the silence and abrupt r- but let me have one more day to review. |
|
No problem, if you want to take "ownership" of a review feel free to assign yourself to such PRs (or do the initial review :^) |
lowr
reviewed
Jul 4, 2023
|
Also, I think indent levels break when the impl in question is not a top-level item of the file. Can you add a test for that, something like the one below? You may want to use mod a {
impl S$0 {
fn foo() {}
}
} |
Veykril
approved these changes
Jul 4, 2023
|
Whoops, didn't meant to do that |
lowr
reviewed
Jul 5, 2023
|
Nice work, thanks! @bors r=Veykril,lowr |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14987 . As the name suggests this assist is used to generate traits from inherent impls while adapting the original impl to fit to the newly generated trait. I made some decisions regarding when the assist should be applicable. These are surely open to discussion. I looking forward to any feedback.