Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor/code: Use @tsconfig/strictest to define type checking rules #15154

Merged
merged 1 commit into from Jun 28, 2023

Conversation

tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzeki tetsuharuohzeki commented Jun 27, 2023

Motivation

This change aims to make it easier to manage tsconfig by @tsconfig/strictest and intend to leave to create "ideal" rules about TypeScript's type checking.

Implementation

This change removes some duplicated rules defined in @tsconfig/strictest and add disabing some strict rules that fails with the current codebase.

Motivation
-----------

This change aims to make it easier to manage tsconfig.
This intend to leave to create "ideal" rules about TypeScript's type checking.

Implementation
---------------

This change removes some duplicated rules defined in `@tsconfig/strictest` and add disabing some strict rules
that fails with the current codebase.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2023
@lnicola
Copy link
Member

lnicola commented Jun 28, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

📌 Commit 0ddf8b6 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

⌛ Testing commit 0ddf8b6 with merge 89d7056...

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 89d7056 to master...

@bors bors merged commit 89d7056 into rust-lang:master Jun 28, 2023
10 checks passed
@tetsuharuohzeki tetsuharuohzeki deleted the tsconfig-strictest branch June 28, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants