internal: add library fixture meta
#15161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally documents the syntax for fixture meta.
rustbot
added
the
S-waiting-on-review
|
we use the term library internally in other places for this as well so thats fine (sourceroot makes a distinction between local and library I think) |
|
I think I'm feeling it's confusing because there are two |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to specify
CrateOriginof a file fixture (this might be a bug?). This PR addslibrarymeta to explicitly specify the fixture to beCrateOrigin::Libraryand also makes sure crates that belong to a library source root are setCrateOrigin::Library.(
libraryisn't really the best name. It essentially means that the crate is outside workspace butnon_workspace_memberfeels a bit too long. Suggestions for the better name would be appreciated)Additionally: