Use anonymous lifetime where possible #15169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
IIRC there is a clippy lint for that, you can use it to check if any of them missed (in case you already didn't do that). |
|
That's what I anticipated, but I couldn't find it. Mind checking it? |
|
It is probably this: https://rust-lang.github.io/rust-clippy/master/#/needless_lifetimes |
|
So I've rechecked but no lints in https://rust-lang.github.io/rust-clippy/master/#/lifetime got triggered by this code :/ I might as well file an issue for clippy. struct S<'a>(&'a i32);
impl<'a> S<'a> {} |
|
It is reported: rust-lang/rust-clippy#10394 So let's merge this. |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because anonymous lifetimes are super cool.
More seriously, I believe anonymous lifetimes, especially those in impl headers, reduce cognitive load to a certain extent because they usually signify that they are not relevant in the signature of the methods within (or that we can apply the usual lifetime elision rules even if they are relevant).