Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #[derive_const(Trait)] #15172

Merged
merged 1 commit into from Jun 29, 2023
Merged

Support #[derive_const(Trait)] #15172

merged 1 commit into from Jun 29, 2023

Conversation

HKalbasi
Copy link
Member

This is a nightly feature used in the standard library.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2023
@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 29, 2023

📌 Commit edc52d3 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 29, 2023

⌛ Testing commit edc52d3 with merge d4820ce...

bors added a commit that referenced this pull request Jun 29, 2023
Support #[derive_const(Trait)]

This is a nightly feature used in the standard library.
@bors
Copy link
Collaborator

bors commented Jun 29, 2023

💔 Test failed - checks-actions

@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 29, 2023

📌 Commit f53f923 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 29, 2023

⌛ Testing commit f53f923 with merge 70ea88e...

bors added a commit that referenced this pull request Jun 29, 2023
Support #[derive_const(Trait)]

This is a nightly feature used in the standard library.
@bors
Copy link
Collaborator

bors commented Jun 29, 2023

💔 Test failed - checks-actions

@HKalbasi
Copy link
Member Author

@bors retry

@bors
Copy link
Collaborator

bors commented Jun 29, 2023

⌛ Testing commit f53f923 with merge b9c3d09...

@lowr
Copy link
Contributor

lowr commented Jun 29, 2023

Hasn't derive_const been removed by rust-lang/rust#110393? The built-in macro and the feature gate still exist, but the standard library seems to have stopped using them at this time?

@bors
Copy link
Collaborator

bors commented Jun 29, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing b9c3d09 to master...

@bors bors merged commit b9c3d09 into rust-lang:master Jun 29, 2023
9 of 10 checks passed
@HKalbasi
Copy link
Member Author

Hmm.. it will at least serve us 13 days until #110393 hits stable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants