Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Drop cross-env npm dep #15175

Merged
merged 1 commit into from Jun 30, 2023
Merged

internal: Drop cross-env npm dep #15175

merged 1 commit into from Jun 30, 2023

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jun 30, 2023

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2023
@@ -39,6 +39,7 @@ export async function getTests(ctx: Context) {
});

suite.addTest("Should support external variables", async () => {
process.env["TEST_VARIABLE"] = "test";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really nice, but should be fine.

@lnicola
Copy link
Member Author

lnicola commented Jun 30, 2023

@bors r=Veykril

@bors
Copy link
Collaborator

bors commented Jun 30, 2023

📌 Commit 477a75d has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 30, 2023

⌛ Testing commit 477a75d with merge d597369...

@bors
Copy link
Collaborator

bors commented Jun 30, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d597369 to master...

@bors bors merged commit d597369 into rust-lang:master Jun 30, 2023
10 checks passed
@lnicola lnicola deleted the cross-env branch June 30, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants