Shuffle some proc_macro_expand query things around #15203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Jul 3, 2023
Shuffle some proc_macro_expand query things around Removes some unnecessary extra work we are doing in proc-macro expansion, and more importantly `Arc` the result of the proc_macro_expand query, that way we can reuse the instance for the `macro_expand` query's result
|
💔 Test failed - checks-actions |
Veykril
force-pushed
the
proc-macro-expand
branch
from
26f7c6a
to
bdc3d0f
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
This oddly increased mem usage on self by 14 and reduced it on webrender by 17 ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some unnecessary extra work we are doing in proc-macro expansion, and more importantly
Arcthe result of the proc_macro_expand query, that way we can reuse the instance for themacro_expandquery's result