Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GATs in bounds for associated types #15211

Merged
merged 1 commit into from Jul 4, 2023

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Jul 4, 2023

Chalk has a dedicated IR for bounds on trait associated type: rust_ir::InlineBound. We have been failing to convert GATs inside those bounds from our IR to chalk IR. This PR provides an easy fix for it: properly take GATs into account during the conversion.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2023
@lowr
Copy link
Contributor Author

lowr commented Jul 4, 2023

r? @flodiebold if you have time.

@flodiebold
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 4, 2023

📌 Commit 9fd5f8c has been approved by flodiebold

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 4, 2023

⌛ Testing commit 9fd5f8c with merge e219999...

@bors
Copy link
Collaborator

bors commented Jul 4, 2023

☀️ Test successful - checks-actions
Approved by: flodiebold
Pushing e219999 to master...

@bors bors merged commit e219999 into rust-lang:master Jul 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants