Make fields of mir::Terminator public

[ChristianSchott]

When trying to use the RA crate, I am unable to access the fields in hir_def::mir::Terminator.
I don't see any reason, why these should be private, especially as the fields of hir_def::mir::Statement are pub.

I am not sure if the fields in hir_def::mir::SwitchTargets should be made pub too, but at least they are read-accessible via some public methods..

Sorry if I missed something, this is my first PR.

[HKalbasi]

This makes sense, I will merge it when bors becomes online. About SwitchTargets since it is exact copy of rustc and there were private there and methods are enough, let's keep them private.

But note that there is no stability guarantees no where in rust-analyzer crates, and things will specially break in mir since it is a work in progress. By the way, what is your use case?

[ChristianSchott]

@HKalbasi Sounds good! No worries, I am aware about the stability of MIR.. the original plan was to access the rustc-mir directly, but that seemed a lot harder and also unstable. So your work on integrating MIR in RA is already a big time safe!
I am trying to create a borrow/lifetime visualization tool similar to RustViz (https://github.com/rustviz/rustviz, but without the need for manual annotations) for making learning Rust easier.. but don't expect too much, I am still very new to Rust myself ^^

[HKalbasi]

Interesting. If you got some where, it might also be possible to merge it in rust-analyzer for easier use and better discoverability. Also note that r-a mir has probably some bugs relative to rustc's, please report if you hit them.

@bors r+

[bors]

📌 Commit 8f612b5 has been approved by HKalbasi

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8f612b5 with merge f6ae0c1...

[bors]

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing f6ae0c1 to master...