Normalize type alias in projected_ty #15297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lowr
reviewed
Jul 17, 2023
| db: &dyn HirDatabase, | ||
| closure_field: impl FnOnce(ClosureId, &Substitution, usize) -> Ty, | ||
| krate: CrateId, | ||
| ) -> Ty { | ||
| if matches!(base.data(Interner).kind, TyKind::Alias(_) | TyKind::AssociatedType(..)) { |
There was a problem hiding this comment.
TyKind::AssociatedType won't get normalized as it represents an unnormalizable associated type as in <T as Trait>::Assoc where T is a generic param.
Also, I noticed you occasionally use ty.data(Interner).kind instead of ty.kind(Interner). Even though they don't make any difference performance-wise, I'd say the latter conveys the intention of the code better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15143