Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Support reading uncompressed proc macro metadata #15301

Merged
merged 1 commit into from Jul 17, 2023

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jul 17, 2023

rust-lang/rust#113695 makes the dylib metadata uncompressed for perf reasons. This commit allows reading both the current compressed and future uncompressed dylib metadata.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2023
@lnicola
Copy link
Member

lnicola commented Jul 17, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

📌 Commit 9d301a2 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

⌛ Testing commit 9d301a2 with merge b415b0b...

bors added a commit that referenced this pull request Jul 17, 2023
Support reading uncompressed proc macro metadata

rust-lang/rust#113695 makes the dylib metadata uncompressed for perf reasons. This commit allows reading both the current compressed and future uncompressed dylib metadata.
@bors
Copy link
Collaborator

bors commented Jul 17, 2023

💔 Test failed - checks-actions

@lnicola
Copy link
Member

lnicola commented Jul 17, 2023

@bors retry

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

⌛ Testing commit 9d301a2 with merge a365e3b...

bors added a commit that referenced this pull request Jul 17, 2023
Support reading uncompressed proc macro metadata

rust-lang/rust#113695 makes the dylib metadata uncompressed for perf reasons. This commit allows reading both the current compressed and future uncompressed dylib metadata.
rust-lang/rust#113695 makes the dylib metadata uncompressed for perf
reasons. This commit allows reading both the current compressed and
future uncompressed dylib metadata.
@bjorn3 bjorn3 force-pushed the uncompressed_dylib_metadata branch from 9d301a2 to 17a6bb5 Compare July 17, 2023 13:31
@lnicola
Copy link
Member

lnicola commented Jul 17, 2023

@bors r-

@lnicola
Copy link
Member

lnicola commented Jul 17, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

📌 Commit 17a6bb5 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

⌛ Testing commit 17a6bb5 with merge 37f84c1...

@lnicola lnicola changed the title Support reading uncompressed proc macro metadata internal: Support reading uncompressed proc macro metadata Jul 17, 2023
@bors
Copy link
Collaborator

bors commented Jul 17, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 37f84c1 to master...

@bors bors merged commit 37f84c1 into rust-lang:master Jul 17, 2023
8 checks passed
@bjorn3 bjorn3 deleted the uncompressed_dylib_metadata branch July 17, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants