fix: Don't provide add_missing_match_arms assist when upmapping match arm list failed
#15345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `str::parse()` rather than `FromStr::from_str()` - use `iter::once()` instead of constructing `Vec` for a single element
rustbot
added
the
S-waiting-on-review
lowr
force-pushed
the
fix/add_missing_match_arms-upmap-failure
branch
from
a89e0e8
to
fbec711
Compare
lowr
changed the title
add_missing_match_arms assist when upmapping match arm list failedadd_missing_match_arms assist when upmapping match arm list failed
Veykril
approved these changes
Aug 1, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
add_missing_match_arms assist when upmapping match arm list failedadd_missing_match_arms assist when upmapping match arm list failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15310
We shouldn't provide the assist when we fail to find the original match arm list.
Note that this PR will temporarily make the assist not applicable when attribute macro operates on the match expression in question, just like the case in #15310, for most of the current stable toolchain users. This is because the sysroot-abi proc-macro-srv on the current stable discards spans for
Groupdelimiters in some code paths, which the popularproc-macro2crate almost always calls, and it makes the identity of match arm list's brackets lost, leading to the upmapping failure. This has been fixed by #14960, which will land in the next stable, 1.71.