Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle #[cfg]s on generic parameters #15350

Merged
merged 4 commits into from Aug 8, 2023
Merged

Handle #[cfg]s on generic parameters #15350

merged 4 commits into from Aug 8, 2023

Conversation

max-heller
Copy link
Contributor

Records attributes on generic parameters in the item tree and filters out generic parameters disabled by #[cfg]s in generic_params_query.

Closes #11756

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2023
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2023
@max-heller
Copy link
Contributor Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2023
@max-heller max-heller requested a review from Veykril August 2, 2023 13:21
@max-heller max-heller requested a review from Veykril August 5, 2023 12:01
@Veykril
Copy link
Member

Veykril commented Aug 8, 2023

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

📌 Commit 50db877 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

⌛ Testing commit 50db877 with merge f98d654...

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f98d654 to master...

@bors bors merged commit f98d654 into rust-lang:master Aug 8, 2023
10 checks passed
@max-heller max-heller deleted the issue-11756 branch August 8, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support #[cfg]s on generic parameters
4 participants
@max-heller @Veykril @bors @rustbot