Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix float parser hack creating empty NameRef tokens #15415

Merged
merged 1 commit into from Aug 8, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 8, 2023

Fixes #15403

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2023
@Veykril
Copy link
Member Author

Veykril commented Aug 8, 2023

Eager macros and the floating point token hack really do make working on r-a not fun at all😩

@Veykril
Copy link
Member Author

Veykril commented Aug 8, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

📌 Commit cba39f8 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

⌛ Testing commit cba39f8 with merge 44eeaea...

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 44eeaea to master...

@bors bors merged commit 44eeaea into rust-lang:master Aug 8, 2023
10 checks passed
@Veykril Veykril deleted the eager-parser-input branch August 8, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to suggest members of object
3 participants