Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: use Cast::cast() instead of explicit interning #15417

Merged
merged 1 commit into from Aug 8, 2023

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Aug 8, 2023

I firmly believe that we should generally use cast() instead of interning GenericArgData to construct GenericArg because it's less verbose and more readable.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2023
@lowr lowr changed the title internal: use Cast::cast() instead of interning GenericArgData internal: use Cast::cast() instead of explicit interning Aug 8, 2023
@HKalbasi
Copy link
Member

HKalbasi commented Aug 8, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

📌 Commit 6aa03c5 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

⌛ Testing commit 6aa03c5 with merge ddbbd6a...

@bors
Copy link
Collaborator

bors commented Aug 8, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing ddbbd6a to master...

@bors bors merged commit ddbbd6a into rust-lang:master Aug 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants