Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor : Deunwrap extract_function #15431

Merged
merged 3 commits into from Sep 11, 2023
Merged

minor : Deunwrap extract_function #15431

merged 3 commits into from Sep 11, 2023

Conversation

alibektas
Copy link
Member

#15398 subtask 5.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2023
@alibektas alibektas changed the title Deunwrap extract_function minor : Deunwrap extract_function Aug 10, 2023
Veykril
Veykril requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a pretty expensive assist, so we should make sure this stays lazy

crates/ide-assists/src/handlers/extract_function.rs Outdated Show resolved Hide resolved
crates/ide-assists/src/handlers/extract_function.rs Outdated Show resolved Hide resolved
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2023
@alibektas
Copy link
Member Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2023
Veykril
Veykril requested changes Sep 8, 2023
View reviewed changes
crates/ide-assists/src/handlers/extract_function.rs Outdated Show resolved Hide resolved
crates/ide-assists/src/handlers/extract_function.rs Outdated Show resolved Hide resolved
crates/ide-assists/src/handlers/extract_function.rs Outdated Show resolved Hide resolved
crates/ide-assists/src/handlers/extract_function.rs Outdated Show resolved Hide resolved
crates/ide-assists/src/handlers/extract_function.rs Outdated Show resolved Hide resolved
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2023
@lnicola lnicola mentioned this pull request Sep 9, 2023
Closed
15 tasks
@alibektas
Copy link
Member Author

It seems like I did more damage than fixing stuff with these last commits 😄. So now I basically took the original version ( without actually reverting it) and changed unwraps to expects

@Veykril
Copy link
Member

Veykril commented Sep 11, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 11, 2023

📌 Commit 0f1673c has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 11, 2023

⌛ Testing commit 0f1673c with merge cc6c820...

@bors
Copy link
Collaborator

bors commented Sep 11, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing cc6c820 to master...

@bors bors merged commit cc6c820 into rust-lang:master Sep 11, 2023
10 checks passed
@alibektas alibektas deleted the deunwrap/extract_function branch September 29, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alibektas @Veykril @bors @rustbot