Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix auto-import (and completions) importing #[doc(hidden)] items #15473

Merged
merged 1 commit into from Aug 17, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 17, 2023

Fixes #9197 and #9911

Turns out while #15472 didn't give access to the import stuff to the IDE layer, these can be fixed already since they use the import map which works in the hir-def crate 🎉

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2023
@Veykril
Copy link
Member Author

Veykril commented Aug 17, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 17, 2023

📌 Commit 637f496 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 17, 2023

⌛ Testing commit 637f496 with merge 44cf174...

@bors
Copy link
Collaborator

bors commented Aug 17, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 44cf174 to master...

@bors bors merged commit 44cf174 into rust-lang:master Aug 17, 2023
10 checks passed
@Veykril Veykril deleted the doc-hidden-imports branch August 17, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import/qualify trait Deref suggesting lazy_static::__Deref instead of std::ops::Deref
3 participants