Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: fix help text for rust-analyzer.check.invocation{Strategy,Location} #15490

Merged
merged 1 commit into from Aug 21, 2023

Conversation

RalfJung
Copy link
Member

I highly doubt that check.invocationLocation only has an effect if cargo.buildScripts.overrideCommand is set -- looks like a copy-paste mistake from buildScripts.invocationLocation to me.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2023
@Veykril
Copy link
Member

Veykril commented Aug 21, 2023

Yep thats a copy paste mistake.
Regarding failing CI thats because you'll need to regenerate some files, but I'll go ahead an do that since that currently requires building the entirety of r-a (#15491).

@Veykril
Copy link
Member

Veykril commented Aug 21, 2023

I guess you beat me to it 😄

@RalfJung
Copy link
Member Author

Ah sorry... yeah I grepped and updated the other files by hand.^^ But it's possible I got that wrong, so if it fails again I will leave it to you. :)

@Veykril
Copy link
Member

Veykril commented Aug 21, 2023

Seems to have worked
@bors r+

@bors
Copy link
Collaborator

bors commented Aug 21, 2023

📌 Commit 887cc48 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 21, 2023

⌛ Testing commit 887cc48 with merge 9b3d034...

@bors
Copy link
Collaborator

bors commented Aug 21, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 9b3d034 to master...

@bors bors merged commit 9b3d034 into rust-lang:master Aug 21, 2023
10 checks passed
@RalfJung RalfJung deleted the check-invocation-help branch August 21, 2023 08:37
@lnicola lnicola changed the title fix help text for rust-analyzer.check.invocation{Strategy,Location} internal: fix help text for rust-analyzer.check.invocation{Strategy,Location} Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants