Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update offset intrinsic to match 1.72 #15512

Merged
merged 3 commits into from Aug 25, 2023
Merged

Update offset intrinsic to match 1.72 #15512

merged 3 commits into from Aug 25, 2023

Conversation

HKalbasi
Copy link
Member

fix #15498

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2023
@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

📌 Commit aa7ed93 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

⌛ Testing commit aa7ed93 with merge ac63e06...

bors added a commit that referenced this pull request Aug 25, 2023
@bors
Auto merge of #15512 - HKalbasi:mir, r=HKalbasi
ac63e06 
Update offset intrinsic to match 1.72

fix #15498
@bors
Copy link
Collaborator

bors commented Aug 25, 2023

💔 Test failed - checks-actions

@lnicola
Copy link
Member

lnicola commented Aug 25, 2023

Needs a cargo fmt on 1.72.

@lnicola
Copy link
Member

lnicola commented Aug 25, 2023

What happens on pre-1.72?

@HKalbasi
Copy link
Member Author

What happens on pre-1.72?

It will return offset generic arg is not provided, then falls back to the non Debug rendering of constants.

@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

📌 Commit ff23f28 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

⌛ Testing commit ff23f28 with merge c4395d3...

bors added a commit that referenced this pull request Aug 25, 2023
@bors
Auto merge of #15512 - HKalbasi:mir, r=HKalbasi
c4395d3 
Update offset intrinsic to match 1.72

fix #15498
@lnicola
Copy link
Member

lnicola commented Aug 25, 2023

Filed #15513 for the CI failure.

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

💔 Test failed - checks-actions

@lnicola
Copy link
Member

lnicola commented Aug 25, 2023 •
edited

Oh, right, can you include the first commit from #15513?

@HKalbasi
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

📌 Commit fa76f60 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

⌛ Testing commit fa76f60 with merge 0a0bb77...

@bors
Copy link
Collaborator

bors commented Aug 25, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 0a0bb77 to master...

@bors bors merged commit 0a0bb77 into rust-lang:master Aug 25, 2023
8 checks passed
@bors bors mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
4 participants
@HKalbasi @bors @lnicola @rustbot