feat: Enable rust_analyzer for cfgs when code is being analyzed by rust-analyzer
#15528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #15574) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Sep 8, 2023
Enable `rust_analyzer` for cfgs when code is being analyzed by rust-analyzer This allows one to have r-a skip analysis/replace macros that work not well with r-a at all by gating them behind this cfg (an example being the `quote` macro which r-a struggles with in terms of performance).
|
Actually, let me change things so that we only set these for the workspace to prevent people from relying on this in published libraries as this is as escape hatch for current r-a problems really. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
rust_analyzer for cfgs when code is being analyzed by rust-analyzerrust_analyzer for cfgs when code is being analyzed by rust-analyzer
anarachnid
added a commit
to anarachnid/rust-analyzer
that referenced
this pull request
Oct 6, 2023
merge commits are not allowed upstream, so I manually copied the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to have r-a skip analysis/replace macros that work not well with r-a at all by gating them behind this cfg (an example being the
quotemacro which r-a struggles with in terms of performance).