Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Add a few more db.unwind_if_cancelled() calls #15549

Merged
merged 1 commit into from Sep 2, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 2, 2023

Judging from a profile sent by a friend, the borrowck query took up a significant amount of time in their project which might be the cause for some unresponsiveness as nothing in the mir stack currently unwinds on cancellation

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2023
@Veykril
Copy link
Member Author

Veykril commented Sep 2, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

📌 Commit 0bf0563 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

⌛ Testing commit 0bf0563 with merge 0e002fe...

@bors
Copy link
Collaborator

bors commented Sep 2, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 0e002fe to master...

@bors bors merged commit 0e002fe into rust-lang:master Sep 2, 2023
8 checks passed
@Veykril Veykril deleted the unwind-if-cancelled branch September 2, 2023 12:59
@lnicola lnicola changed the title Add a few more db.unwind_if_cancelled() calls internal: Add a few more db.unwind_if_cancelled() calls Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants