internal: Bump rustc-perf checkout for metrics, replace webrender, diesel and ripgrep with newer versions
#15552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @lnicola (since you've seen it already :^) Gonna check how much time we get back to spent on new targets after this has been merged |
lnicola
approved these changes
Sep 3, 2023
|
I added an assert that checks the paths (otherwise we do perf on the rustc-perf repo instead if the path is mistyped thanks to how our discovery works 😅), so they are good @bors r=lnicola |
bors
added a commit
that referenced
this pull request
Sep 3, 2023
Bump `rustc-perf` checkout for metrics, replace webrender, diesel and ripgrep with newer versions The previous versions were removed hence the updates. The metric results for the changed ones are disconnected now as to not muddle things up. I think it's worth it for us to occasionally bump the `rustc-perf` checkout, as it allows us to include more interesting new targets. Notably, the newer diesel is 3 times as fast to analyze as the one of the current checkout.
|
@bors r- |
|
☀️ Try build successful - checks-actions |
|
Had to change CI to pick up the new files |
bors
added a commit
that referenced
this pull request
Sep 3, 2023
Bump `rustc-perf` checkout for metrics, replace webrender, diesel and ripgrep with newer versions The previous versions were removed hence the updates. The metric results for the changed ones are disconnected now as to not muddle things up. I think it's worth it for us to occasionally bump the `rustc-perf` checkout, as it allows us to include more interesting new targets. Notably, the newer diesel is 3 times as fast to analyze as the one of the current checkout.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
rustc-perf checkout for metrics, replace webrender, diesel and ripgrep with newer versionsrustc-perf checkout for metrics, replace webrender, diesel and ripgrep with newer versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous versions were removed hence the updates. The metric results for the changed ones are disconnected now as to not muddle things up.
I think it's worth it for us to occasionally bump the
rustc-perfcheckout, as it allows us to include more interesting new targets.Notably, the newer diesel is 3 times as fast to analyze as the one of the current checkout.