internal: code: remove rust-analyzer.discoverProjectCommand in favor of a companion extension
#15558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
force-pushed
the
davidbarsky/add-companion-extension-integration
branch
from
54afe23
to
68781ae
Compare
|
Sorry about all the commits—let me know if you'd me like to squash them. I wrote all of them because the pull request view wasn't updating due to GitHub's outage earlier in the day. |
Veykril
approved these changes
Sep 8, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
rust-analyzer.discoverProjectCommand in favor of a companion extensionrust-analyzer.discoverProjectCommand in favor of a companion extension
davidbarsky
deleted the
davidbarsky/add-companion-extension-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to remove this functionality from the
rust-analyzerand move it into a dedicated extension responsible for this. Selfishly, this changes makes it tenable to do progress reporting to the editor and potentially do some more complicated things around managing which workspaces are being used.