Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to show full function signatures in completion docs #15582

Merged
merged 5 commits into from Sep 24, 2023

Conversation

vxpm
Copy link
Contributor

@vxpm vxpm commented Sep 9, 2023

implements #15538

with "rust-analyzer.completion.fullFunctionSignatures.enable": false:
image

with "rust-analyzer.completion.fullFunctionSignatures.enable": true:
image

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2023
@HKalbasi
Copy link
Member

Thanks for the PR. Could you please add some tests for the feature added?

@vxpm
Copy link
Contributor Author

vxpm commented Sep 23, 2023

let me know if there's anything else i can improve

@HKalbasi
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Sep 24, 2023

📌 Commit 10fae62 has been approved by HKalbasi

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 24, 2023

⌛ Testing commit 10fae62 with merge e5e937a...

@bors
Copy link
Collaborator

bors commented Sep 24, 2023

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing e5e937a to master...

@bors bors merged commit e5e937a into rust-lang:master Sep 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants