Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Diagnose private fields in record constructor #15584

Merged
merged 2 commits into from Sep 9, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 9, 2023

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2023
@Veykril
Copy link
Member Author

Veykril commented Sep 9, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 9, 2023

📌 Commit 8f5fee4 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 9, 2023

⌛ Testing commit 8f5fee4 with merge a3cfb45...

@bors
Copy link
Collaborator

bors commented Sep 9, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a3cfb45 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Sep 9, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a3cfb45 to master...

@bors bors merged commit a3cfb45 into rust-lang:master Sep 9, 2023
10 checks passed
@bors
Copy link
Collaborator

bors commented Sep 9, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@lnicola lnicola changed the title Diagnose private fields in record constructor feat: Diagnose private fields in record constructor Sep 9, 2023
@lnicola
Copy link
Member

lnicola commented Sep 11, 2023

image

@Veykril Veykril deleted the diag-private-field-constructor branch September 26, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants