Switch to in-tree rustc dependencies with a cfg flag #15616
Conversation
rustbot
added
the
S-waiting-on-review
HKalbasi
force-pushed
the
rustc-deps
branch
2 times, most recently
from
8cb5a84
to
11470a6
Compare
It enables the |
HKalbasi
force-pushed
the
rustc-deps
branch
from
11470a6
to
f4704bc
Compare
|
This will probably make syncs harder, but I think it does worth it. Feel free to revert if it ended up breaking something or caused too much trouble. @bors r+ |
|
☀️ Test successful - checks-actions |
I hope not 😬. |
|
Not a fan of the implications this has for our dependency graph. This is probably fine right now but won't scale in the future. |
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| #![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)] | |||
| #![allow(rustdoc::private_intra_doc_links)] | |||
| #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] | |||
| in-rust-tree = [ | ||
| "sysroot-abi", | ||
| "ide/in-rust-tree", | ||
| "syntax/in-rust-tree", | ||
| "parser/in-rust-tree", | ||
| "rustc-dependencies/in-rust-tree", | ||
| "hir-def/in-rust-tree", | ||
| "hir-ty/in-rust-tree", | ||
| ] |
There was a problem hiding this comment.
Not a fan of this either, this will ultimately end up with mentioning almost all of our crates at some point
There was a problem hiding this comment.
Me too, maybe a non cargo cfg is a better fit here?
There was a problem hiding this comment.
Yes, I think it'd be better if we could make it so that this doesn't thread through all the cargo files if possible
| @@ -8,6 +8,7 @@ | |||
| //! actually true. | |||
|
|
|||
| #![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)] | |||
| #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] | |||
There was a problem hiding this comment.
This feature is needed even if you import the rustc private crates indirectly, which I think is unnecessarily too aggressive. Is there any way to depend on the crates in the rustc workspace without this feature? Clippy and Miri use this, but they are fine with nightly and feature flags.
There was a problem hiding this comment.
Ah right, since we might mention the items from those crates now. Well that's unfortunate but not much we can do in that case. Would be nice to add a comment regarding that then.
| @@ -19,6 +19,7 @@ | |||
| //! [RFC]: <https://github.com/rust-lang/rfcs/pull/2256> | |||
| //! [Swift]: <https://github.com/apple/swift/blob/13d593df6f359d0cb2fc81cfaac273297c539455/lib/Syntax/README.md> | |||
|
|
|||
| #![cfg_attr(feature = "in-rust-tree", feature(rustc_private))] | |||
We can use this flag to detect and prevent breakages in rustc CI. (see #14846 and #15569)
TheIN_RUSTC_REPOSITORYis just a placeholder. Is there any existing cfg flag that rustc CI sets?