Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backtick to surrounding and auto-closing pairs #15668

Merged
merged 1 commit into from Oct 5, 2023

Conversation

connorskees
Copy link
Contributor

Makes backticks always complete as a pair and also surround the current selection, similar to double quotes. This is useful primarily in the context of markdown doc comments, but is applied globally for simplicity.

Closes #11381

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2023
@Veykril
Copy link
Member

Veykril commented Oct 5, 2023

Makes sense to me 👍
@bors r+

@bors
Copy link
Collaborator

bors commented Oct 5, 2023

📌 Commit 6ca48d9 has been approved by Veykril

It is now in the queue for this repository.

@lnicola
Copy link
Member

lnicola commented Oct 5, 2023

@bors retry

@lnicola
Copy link
Member

lnicola commented Oct 5, 2023

I wonder if we should ask for access to that RIIR bors version..

@Veykril
Copy link
Member

Veykril commented Oct 5, 2023

Given we don't use any fancy functionality that seems fine to me

@Veykril Veykril closed this Oct 5, 2023
@Veykril Veykril reopened this Oct 5, 2023
@bors
Copy link
Collaborator

bors commented Oct 5, 2023

⌛ Testing commit 6ca48d9 with merge 54866a0...

@bors
Copy link
Collaborator

bors commented Oct 5, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 54866a0 to master...

@bors bors merged commit 54866a0 into rust-lang:master Oct 5, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add backticks (`) to surrounding pairs when editing doc comments
6 participants