Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pick a better name for variables introduced by replace_is_some_with_if_let_some #15775

Merged
merged 1 commit into from Oct 18, 2023
Merged

fix: pick a better name for variables introduced by replace_is_some_with_if_let_some #15775

merged 1 commit into from Oct 18, 2023

Conversation

Young-Flash
Copy link
Member

@Young-Flash Young-Flash commented Oct 17, 2023 •
edited

change generated variable name in replace_is_some_with_if_let_some assist

close #15765

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. has-merge-commits labels Oct 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2023

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 18, 2023
@Young-Flash Young-Flash force-pushed the refactor branch 2 times, most recently from ec3a513 to 1a0fe58 Compare October 18, 2023 02:22
@lnicola
Copy link
Member

lnicola commented Oct 18, 2023

Quick r? please, @Veykril?

@Veykril
Copy link
Member

Veykril commented Oct 18, 2023

Would be nice if the bot removed the merge commit label once its no longer applicable
@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2023

📌 Commit 1a0fe58 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 18, 2023

⌛ Testing commit 1a0fe58 with merge 7f1e6fd...

@bors
Copy link
Collaborator

bors commented Oct 18, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7f1e6fd to master...

@bors bors merged commit 7f1e6fd into rust-lang:master Oct 18, 2023
19 checks passed
@lnicola lnicola changed the title refactor: change generated variable name fix: pick a better name for variables introduced by replace_is_some_with_if_let_some Oct 18, 2023
@Young-Flash Young-Flash deleted the refactor branch October 18, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
has-merge-commits S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace_is_method_with_if_let_method should reuse binding or function name instead of _tmp
5 participants
@Young-Flash @rustbot @lnicola @Veykril @bors