fix: Recover from missing argument in call expressions #16124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ohno418
commented
Dec 14, 2023
ohno418
force-pushed
the
call-expr-missing-arg
branch
from
11dd28f
to
fcf2d9a
Compare
Veykril
reviewed
Dec 15, 2023
Veykril
added
S-waiting-on-author
Previously, when parsing an argument list with a missing argument (e.g., `(a, , b)` in `foo(a, , b)`), the parser would stop upon an unexpected token (at the second comma in the example), resulting in an incorrect parse tree. This commit improves error handling in such cases, ensuring a more accurate parse tree is built.
Veykril
force-pushed
the
call-expr-missing-arg
branch
from
fcf2d9a
to
974e69b
Compare
|
I'm cleaning up our PRs so I've went and finished the PR. Thanks for the work! |
|
☀️ Test successful - checks-actions |
|
@Veykril |
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when parsing an argument list with a missing argument (e.g.,
(a, , b)infoo(a, , b)), the parser would stop upon an unexpected token (at the second comma in the example), resulting in an incorrect parse tree.This commit improves error handling in such cases, ensuring a more accurate parse tree is built.
Fixes #15683.