Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Add unstable config for loading the sysroot sources via cargo metadata #16356

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 13, 2024

cc #7637

This takes the approach of having cargo metadata generate a lock file that we then delete again, hence why this is behind a flag. If people need this for their workflow they can just enable it, if not, they are probably better off keeping it disabled. example

image
hashbrown resolves as a dependency of std with that enabled

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2024
@Veykril Veykril force-pushed the sysroot-metadata branch 2 times, most recently from 5c3ef9b to 56b3768 Compare January 15, 2024 08:36
@Veykril
Copy link
Member Author

Veykril commented Jan 15, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

📌 Commit c7eb52d has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

⌛ Testing commit c7eb52d with merge a616c4d...

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a616c4d to master...

@bors bors merged commit a616c4d into rust-lang:master Jan 15, 2024
10 checks passed
@Veykril Veykril deleted the sysroot-metadata branch January 15, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants